Feature/expansion remove logic #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Chernyshov <[email protected]>
Signed-off-by: Alexey Chernyshov <[email protected]> # Conflicts: # notary-commons/src/main/kotlin/com/d3/commons/expansion/ServiceExpansion.kt
Signed-off-by: Alexey Chernyshov <[email protected]>
e34098d to
e3551c4
Compare
Signed-off-by: Alexey Chernyshov <[email protected]>
Signed-off-by: Alexey Chernyshov <[email protected]>
8201d41 to
54f84eb
Compare
Signed-off-by: Alexey Chernyshov <[email protected]>
Signed-off-by: Alexey Chernyshov <[email protected]>
Signed-off-by: Alexey Chernyshov <[email protected]>
f23db2e to
99d4c69
Compare
notary-commons/src/main/kotlin/com/d3/commons/expansion/ExpansionUtils.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexey Chernyshov <[email protected]>
Mingela
approved these changes
Jun 26, 2019
notary-commons/src/main/kotlin/com/d3/commons/expansion/ExpansionUtils.kt
Outdated
Show resolved
Hide resolved
| } else { | ||
| logger.warn("No account with id ${expansionDetails.accountIdToExpand} was found. Cannot expand.") | ||
| } | ||
| expansionLogic(expansionDetails, txHash, block.blockV1.payload.createdTime) |
Contributor
There was a problem hiding this comment.
Why we need txHash?
Member
Author
There was a problem hiding this comment.
To check tx in Ethereum expansion.
Signed-off-by: Alexey Chernyshov <[email protected]>
…into feature/expansion-remove-logic
dolgopolovwork
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Usage Examples or Tests [optional]