Fix make_array() call #633
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array parameter was named "alloc", renamed to "a" to match the other make_array() overloads.
The make_array(array, allocator_type) overload generated a compile error when it was instantiated because there was no corresponding basic_json constructor. This adds that missing constructor. A matching object constructor is also added for completeness.
Owner
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing allocator-aware array and object constructors
The
make_array(array, allocator_type)overload generated a compile errorwhen it was instantiated because there was no corresponding
basic_jsonconstructor. This adds that missing constructor. A matching
objectconstructor is also added for completeness.