Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

Mrp 2020#106

Merged
danielhers merged 8 commits intodanielhers:mrpfrom
OfirArviv:mrp
Oct 14, 2020
Merged

Mrp 2020#106
danielhers merged 8 commits intodanielhers:mrpfrom
OfirArviv:mrp

Conversation

@OfirArviv
Copy link
Collaborator

@OfirArviv OfirArviv commented Aug 10, 2020

No description provided.

@danielhers
Copy link
Owner

danielhers commented Aug 10, 2020

Thanks, very helpful. Any script updates for training / prediction?

@OfirArviv
Copy link
Collaborator Author

OfirArviv commented Aug 10, 2020 •
edited
Loading

Thanks, very helpful. Any script updates for training / prediction?

It the same really. I just used yours. So no.

danielhers
danielhers suggested changes Sep 4, 2020
View reviewed changes
tupa/config.py
EDGE_LABELS_NUM = {"amr": 141, "dm": 59, "psd": 90, "eds": 10, "ucca": 15}
NODE_LABELS_NUM = {"amr": 1000, "dm": 1000, "psd": 1000, "eds": 1000, "ucca": 0, "ptg": 1000}
NODE_PROPERTY_NUM = {"amr": 1000, "dm": 510, "psd": 1000, "eds": 1000, "ucca": 0, "ptg": 1000}
EDGE_LABELS_NUM = {"amr": 141, "dm": 59, "psd": 90, "eds": 10, "ucca": 15, "ptg": 150}
Copy link
Owner

@danielhers danielhers Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRG?

Copy link
Collaborator Author

@OfirArviv OfirArviv Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values are enough

@OfirArviv
Copy link
Collaborator Author

OfirArviv commented Sep 12, 2020

Still failing due to EDS. I'll check later why

@danielhers
Copy link
Owner

danielhers commented Oct 13, 2020

Hey @OfirArviv , when you get a chance, could you fix the code to make this PR pass?
https://travis-ci.com/github/danielhers/tupa/jobs/384233352#L806
For EDS, the oracle returns REDUCE for an unanchored poss node, which violates the constraints; but I think this node is just unanchored in the gold graph so the constraints should allow reducing it.

@OfirArviv
Copy link
Collaborator Author

OfirArviv commented Oct 13, 2020

Hey @OfirArviv , when you get a chance, could you fix the code to make this PR pass?
https://travis-ci.com/github/danielhers/tupa/jobs/384233352#L806
For EDS, the oracle returns REDUCE for an unanchored poss node, which violates the constraints; but I think this node is just unanchored in the gold graph so the constraints should allow reducing it.

Sorry. With all the pressure forgot about it. The question is, why it broke? We didn't change anything related to EDS as far as I can see. Did something changed in the build?

@danielhers
Copy link
Owner

danielhers commented Oct 14, 2020

You are right. I finally figured out it's due to a bug in mtool: cfmrp/mtool#84.

@danielhers danielhers merged commit e5536d8 into danielhers:mrp Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danielhers danielhers danielhers requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OfirArviv @danielhers