Added strokeStyle option to crosshair plugin to allow color choice.#955
Merged
mirabilos merged 1 commit intodanvk:masterfrom Jan 25, 2023
Merged
Added strokeStyle option to crosshair plugin to allow color choice.#955mirabilos merged 1 commit intodanvk:masterfrom
mirabilos merged 1 commit intodanvk:masterfrom
Conversation
mirabilos
requested changes
Jan 5, 2023
| this.canvas_ = document.createElement("canvas"); | ||
| opt_options = opt_options || {}; | ||
| this.direction_ = opt_options.direction || null; | ||
| this.strokeStyle = opt_options.strokeStyle || "rgb(0,0,0,0.3)"; |
Collaborator
There was a problem hiding this comment.
"rgba(0, 0, 0, 0.3)" to be exact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed this functionality for my graphs because I am working in a dark theme. The default color was hardly visible.
Maybe the option should be called 'color' instead of strokeStyle, or maybe color can be an object inside strokeStyle
But I let it remain consistent with the current variables for now.
What do you think?