Skip to content

Add missing semicolon in externs#964

Merged
danvk merged 1 commit intodanvk:masterfrom
jkuszmaul:master
May 26, 2019
Merged

Add missing semicolon in externs#964
danvk merged 1 commit intodanvk:masterfrom
jkuszmaul:master

Conversation

@jkuszmaul
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 90.199% when pulling 28560a9 on jkuszmaul:master into da2a028 on danvk:master.

@danvk
Copy link
Owner

danvk commented May 26, 2019

Thanks. Are you using dygraphs with Closure Compiler?

@danvk danvk merged commit 27cee3f into danvk:master May 26, 2019
@jkuszmaul
Copy link
Contributor Author

I am not compiling dygraph myself; I'm taking the released dygraph.min.js you provide and using the externs file with closure to get the declarations.

I should probably make a pull request for them as well, but I also had to:

  • Add an @externs tag in the file comment for the externs file.
  • Changed the HTMLDivElement to just an Element, because I was too lazy to find the proper way to get an HTMLDivElement object out of the DOM (I'm not a javascript person normally--I just needed to create a small plotting webpage for a project).

pawelzwronek pushed a commit to pawelzwronek/dygraphs that referenced this pull request Oct 17, 2020
pawelzwronek added a commit to pawelzwronek/dygraphs that referenced this pull request Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants