Merged
Conversation
Owner
|
Thanks. Are you using dygraphs with Closure Compiler? |
Contributor
Author
|
I am not compiling dygraph myself; I'm taking the released dygraph.min.js you provide and using the externs file with closure to get the declarations. I should probably make a pull request for them as well, but I also had to:
|
pawelzwronek
pushed a commit
to pawelzwronek/dygraphs
that referenced
this pull request
Oct 17, 2020
pawelzwronek
added a commit
to pawelzwronek/dygraphs
that referenced
this pull request
Oct 17, 2020
This reverts commit 15d84fc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.