feat(context): Various UI improvements for Context Base (Part 1/2) #15413

jjoyce0510 · 2025-11-26T04:39:48Z

Summary

In this PR:

Remove context documents from primary search by default (not ready yet)
Add specific document search capability from context sidebar
Combine related assets and related documents into a single well-designed section under the document editor
Hide related assets (distracting) when it edit mode
Fix bug related to parsing the URN of tagged assets
Minor styling improvements in a few different locations
Support manually linking related assets and documents via a new EntitySearchDropdown.tsx which is now reused in multiple places!
Adding simple delete for related assets and context docs
Match hover styles between context base and other nav sidebar items.

Screenshots

alwaysmeticulous · 2025-11-26T04:47:43Z

✅ Meticulous spotted 0 visual differences across 998 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

_{Expected differences? Click here. Last updated for commit 48bbce0. This comment will update as new commits are pushed.}

codecov · 2025-11-26T04:50:28Z

Bundle Report

Changes will increase total bundle size by 10.13kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	28.72MB	10.13kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	10.13kB	19.09MB	0.05%

Files in assets/index-*.js:

./src/app/entityV2/document/DocumentNativeProfile.tsx → Total Size: 3.66kB
./src/app/homeV2/layout/sidebar/documents/ContextGroupHeader.tsx → Total Size: 3.52kB
./src/app/homeV2/layout/sidebar/documents/SearchDocumentPopover.tsx → Total Size: 3.86kB
./src/app/homeV2/layout/sidebar/documents/SearchResultItem.tsx → Total Size: 4.42kB
./src/app/document/hooks/useUpdateDocument.ts → Total Size: 3.99kB
./src/app/homeV2/layout/sidebar/documents/DocumentTreeItem.tsx → Total Size: 5.46kB
./src/app/entityV2/document/summary/EditableContent.tsx → Total Size: 7.8kB
./src/app/entityV2/document/summary/RelatedSection.tsx → Total Size: 4.64kB
./src/app/entityV2/shared/EntitySearchSelect/EntitySearchDropdown.tsx → Total Size: 5.15kB
./src/app/entityV2/document/DocumentEntity.tsx → Total Size: 3.85kB
./src/app/homeV2/layout/sidebar/documents/DocumentTreeEmptyState.tsx → Total Size: 717 bytes
./src/app/homeV2/reference/sections/EntityLink.tsx → Total Size: 4.07kB
./src/app/homeV2/layout/sidebar/documents/MoveDocumentPopover.tsx → Total Size: 6.03kB
./src/app/homeV2/layout/sidebar/documents/DocumentActionsMenu.tsx → Total Size: 4.32kB
./src/app/entityV2/document/summary/AddRelatedEntityDropdown.tsx → Total Size: 2.88kB
./src/app/document/hooks/useExtractMentions.ts → Total Size: 741 bytes
./src/app/homeV2/layout/sidebar/documents/useContextMenuItems.tsx → Total Size: 1.84kB

codecov · 2025-11-26T04:52:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

chriscollins3456

nice this makes sense. there's a few things that could use some cleanup and i would love to have consensus on what entity select we're using going forward

nothing blocking approval though!

chriscollins3456 · 2025-11-26T22:30:48Z

datahub-web-react/src/app/entityV2/document/summary/AddRelatedEntityDropdown.tsx

+            // Reset to initial state when closing
+            setSelectedUrns(initialSelectedUrns);
+        } catch (error) {
+            console.error('Failed to update related entities:', error);


could show the user an error here

chriscollins3456 · 2025-11-26T22:45:49Z

datahub-web-react/src/app/entityV2/document/summary/RelatedSection.tsx

+    const userContext = useUserContext();
+
+    // Entity types that can be related (based on RelatedAsset.pdl)
+    // I don't love this, but I do want to enable searching for documents


yeah i feel that we will definitely forget to add something to this list in the future..

that being said i don't see an obvious solution without muddying up our API for a specific use case like this

chriscollins3456 · 2025-11-26T22:50:12Z

datahub-web-react/src/app/entityV2/document/summary/RelatedAssetsSection.tsx

    relatedAssets?: DocumentRelatedAsset[];
 }

 export const RelatedAssetsSection: React.FC<RelatedAssetsSectionProps> = ({ relatedAssets }) => {


is this component still used after replacing with RelatedSection?

Good call - removing!

chriscollins3456 · 2025-11-26T22:50:31Z

datahub-web-react/src/app/entityV2/document/summary/RelatedDocumentsSection.tsx

@@ -34,7 +34,7 @@ export const RelatedDocumentsSection: React.FC<RelatedDocumentsSectionProps> = (

    return (


same - is this used elsewhere still?

chriscollins3456 · 2025-11-26T22:51:25Z

datahub-web-react/src/app/entityV2/shared/EntitySearchSelect/EntitySearchDropdown.tsx

+ * Handles all search logic internally and provides a clean interface.
+ * Includes the Dropdown wrapper, so consumers don't need to wrap it themselves.
+ */
+export const EntitySearchDropdown: React.FC<EntitySearchDropdownProps> = ({


at some point soon we gotta consolidate everything to the final entity selection dropdown and pick our best implementation. too many floating around out there it's hard to know what to use

Yes agreed. This is the one i've used for the newer Access Requests feature (so users can search + select an entity) and now this feature -but those are the only two use cases that are curretly using this..

…atahub-project#15413) Co-authored-by: John Joyce <[email protected]>

Adding checkpoints

4f3b4a3

github-actions bot added product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests labels Nov 26, 2025

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 26, 2025

Final fixups

5a24d38

github-actions bot deployed to datahub-project-web-react (Preview) November 26, 2025 04:46 View deployment

Fix final styling

48bbce0

github-actions bot deployed to datahub-project-web-react (Preview) November 26, 2025 05:04 View deployment

vercel bot deployed to Preview November 26, 2025 05:19 View deployment

chriscollins3456 approved these changes Nov 26, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 26, 2025

jjoyce0510 merged commit 312af9d into master Dec 1, 2025
69 of 70 checks passed

jjoyce0510 deleted the jj--add-context-docs-ui-v2-part2 branch December 1, 2025 04:28

Tim-Visser pushed a commit to Tim-Visser/datahub that referenced this pull request Dec 1, 2025

feat(context): Various UI improvements for Context Base (Part 1/2) (d…

ee5984c

…atahub-project#15413) Co-authored-by: John Joyce <[email protected]>

yonglingsong pushed a commit to yonglingsong/datahub that referenced this pull request Dec 2, 2025

feat(context): Various UI improvements for Context Base (Part 1/2) (d…

781bd5a

…atahub-project#15413) Co-authored-by: John Joyce <[email protected]>

		@@ -34,7 +34,7 @@ export const RelatedDocumentsSection: React.FC<RelatedDocumentsSectionProps> = (

		return (

feat(context): Various UI improvements for Context Base (Part 1/2) #15413

feat(context): Various UI improvements for Context Base (Part 1/2) #15413

Uh oh!

Conversation

jjoyce0510 commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Uh oh!

alwaysmeticulous bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jjoyce0510 commented Nov 26, 2025 •

edited

Loading

alwaysmeticulous bot commented Nov 26, 2025 •

edited

Loading

codecov bot commented Nov 26, 2025 •

edited

Loading

codecov bot commented Nov 26, 2025 •

edited

Loading