fix(describegpt): remove confusing redundant count for "Other" values in the Data Dictionary Examples column #3449
+1,321
−861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es in Examples column
Remove trailing parenthetical counts from values like "Other (n)" when f.rank == 0.0 so the parenthetical count isn't duplicated (the numeric count is already shown separately). Introduce raw_value and apply truncation to the cleaned value before formatting (uses rfind(" (") to strip the last parenthetical), preserving the displayed [count].
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates describegpt’s code-based dictionary generation to avoid showing a redundant “unique values” parenthetical in the Examples column for rank-0 (“Other”) frequency buckets, and refreshes the corresponding documentation examples.
Changes:
- Strip the trailing
(n)portion from rank-0 frequency values (e.g.,Other (123)→Other) when rendering Examples. - Regenerate/refresh
describegptdocumentation outputs to reflect the new Examples formatting.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/cmd/describegpt.rs |
Adjusts Examples rendering for rank-0 (“Other”) bucket values to drop the redundant parenthetical count. |
docs/describegpt/nyc311-describegpt.md |
Updates generated example output; now shows Other [...] instead of Other (n) [...]. |
docs/describegpt/nyc311-describegpt-spanish.md |
Same refresh for Spanish example output. |
docs/describegpt/nyc311-describegpt-mandarin.md |
Same refresh for Mandarin example output. |
…r" in Examples column Append "…" to frequency bucket entries (rank=0) after stripping the parenthetical count, so bucket "Other… [4,091]" is visually distinct from a literal data value "Other [2,006]". This addresses the Copilot review feedback on PR #3449 about ambiguous output in fields like Taxi Pick Up Location. - Add ellipsis suffix to bucket entries for disambiguation - Add describegpt_other_bucket_disambiguation test - Update all sample doc files with the new Other… format Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.