fix(ext/node): emit error event for worker with missing main module#32062
Open
littledivy wants to merge 7 commits intodenoland:mainfrom
Open
fix(ext/node): emit error event for worker with missing main module#32062littledivy wants to merge 7 commits intodenoland:mainfrom
littledivy wants to merge 7 commits intodenoland:mainfrom
Conversation
Signed-off-by: Divy <dj.srivastava23@gmail.com>
Signed-off-by: Divy <dj.srivastava23@gmail.com>
bartlomieju
reviewed
Feb 5, 2026
| }, | ||
| }); | ||
|
|
||
| Deno.test({ |
Member
There was a problem hiding this comment.
This is now covered by parallel/test-worker-esm-missing-main.js
bartlomieju
reviewed
Feb 5, 2026
| // "Cannot find module" format so it matches Node.js error behavior. | ||
| let e = if internal_handle.worker_type == WorkerThreadType::Node { | ||
| let msg = e.to_string(); | ||
| if msg.starts_with("Module not found") { |
Member
There was a problem hiding this comment.
This is not great, but I don't have a better idea and it's unlikely we'll ever change this error.
bartlomieju
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
test-worker-esm-missing-main.jstest