Sourcery refactored master branch #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def save(self, *args, **kwargs): | ||
| if self.full_name == "" or self.full_name == None: | ||
| if self.full_name == "" or self.full_name is None: |
Author
There was a problem hiding this comment.
Function Profile.save refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
| def sender_profile(self): | ||
| sender_profile = Profile.objects.get(user=self.sender) | ||
| return sender_profile | ||
| return Profile.objects.get(user=self.sender) |
Author
There was a problem hiding this comment.
Function ChatMessage.sender_profile refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
77
to
78
| reciever_profile = Profile.objects.get(user=self.reciever) | ||
| return reciever_profile | ||
| return Profile.objects.get(user=self.reciever) |
Author
There was a problem hiding this comment.
Function ChatMessage.reciever_profile refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| self.Meta.depth = 0 | ||
| else: | ||
| self.Meta.depth = 3 | ||
| self.Meta.depth = 0 if request and request.method=='POST' else 3 |
Author
There was a problem hiding this comment.
Function ProfileSerializer.__init__ refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-93
to
+90
| if request and request.method=='POST': | ||
| self.Meta.depth = 0 | ||
| else: | ||
| self.Meta.depth = 2 | ||
| self.Meta.depth = 0 if request and request.method=='POST' else 2 |
Author
There was a problem hiding this comment.
Function MessageSerializer.__init__ refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
|
|
||
| todo = Todo.objects.filter(user=user) | ||
| return todo | ||
| return Todo.objects.filter(user=user) |
Author
There was a problem hiding this comment.
Function TodoListView.get_queryset refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-73
to
+72
| todo = Todo.objects.get(id=todo_id, user=user) | ||
|
|
||
| return todo | ||
| return Todo.objects.get(id=todo_id, user=user) |
Author
There was a problem hiding this comment.
Function TodoDetailView.get_object refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-101
to
-117
| messages = ChatMessage.objects.filter( | ||
| id__in = Subquery( | ||
| return ChatMessage.objects.filter( | ||
| id__in=Subquery( | ||
| User.objects.filter( | ||
| Q(sender__reciever=user_id) | | ||
| Q(reciever__sender=user_id) | ||
| ).distinct().annotate( | ||
| Q(sender__reciever=user_id) | Q(reciever__sender=user_id) | ||
| ) | ||
| .distinct() | ||
| .annotate( | ||
| last_msg=Subquery( | ||
| ChatMessage.objects.filter( | ||
| Q(sender=OuterRef('id'),reciever=user_id) | | ||
| Q(reciever=OuterRef('id'),sender=user_id) | ||
| ).order_by('-id')[:1].values_list('id',flat=True) | ||
| Q(sender=OuterRef('id'), reciever=user_id) | ||
| | Q(reciever=OuterRef('id'), sender=user_id) | ||
| ) | ||
| .order_by('-id')[:1] | ||
| .values_list('id', flat=True) | ||
| ) | ||
| ).values_list('last_msg', flat=True).order_by("-id") | ||
| ) | ||
| .values_list('last_msg', flat=True) | ||
| .order_by("-id") | ||
| ) | ||
| ).order_by("-id") | ||
|
|
||
| return messages |
Author
There was a problem hiding this comment.
Function MyInbox.get_queryset refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-125
to
+128
| messages = ChatMessage.objects.filter(sender__in=[sender_id, reciever_id], reciever__in=[sender_id, reciever_id]) | ||
| return messages | ||
| return ChatMessage.objects.filter( | ||
| sender__in=[sender_id, reciever_id], | ||
| reciever__in=[sender_id, reciever_id], | ||
| ) |
Author
There was a problem hiding this comment.
Function GetMessages.get_queryset refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!