Fix: --help summary for subcommands shows parents summary#12
Merged
devnote-dev merged 1 commit intodevnote-dev:mainfrom Sep 17, 2023
Merged
Conversation
devnote-dev
approved these changes
Sep 17, 2023
Owner
devnote-dev
left a comment
There was a problem hiding this comment.
Good catch! Updating the formatter specs is fine, thank you 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression slipped through here b03b7f4#diff-45901be25b8751956836db23748983233566901600112a2ce1c058633d245c0dL89 where when showing the help template subcommands would show the summary of the parent rather than their own defined summaries
Using the "greet" example with a summary added for
MainCommandandWelcomeCommandgreet.cr
welcome_command.cr
Main
This branch
I opted to update existing formatter specs but if you'd prefer to have new specs in a separate file I'd be more than happy to make the change :~)