change: when stopping upstream/downstream, also close grpc connections #2739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
Signed-off-by: Thorsten Klein <[email protected]>
3b0c4e8 to
cd3f61e
Compare
FabianKramm
approved these changes
Oct 19, 2023
Collaborator
FabianKramm
left a comment
There was a problem hiding this comment.
@iwilltry42 thanks a lot for the PR! LGTM, good catch!
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2738
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace left over orphaned GRPC connections when pods are removed.
What else do we need to know?
This reduces the annoying grpc logs to 2 coming from the ping, just before the connection gets closed.