Select instruction with non-empty function in coverage block [TG-2341] #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Feb 5, 2018
| @@ -63,6 +63,7 @@ cover_basic_blockst::cover_basic_blockst(const goto_programt &_goto_program) | |||
|
|
|||
| // set representative program location to instrument | |||
| if( | |||
| !it->function.empty() && | |||
There was a problem hiding this comment.
This should be an invariant, I'd say. So I'd turn this on its head: fix the code that generates new instructions without setting their function field.
There was a problem hiding this comment.
Correct. Let me check how big this piece of work will be. I will then put an INVARIANT in goto_programt::update.
There was a problem hiding this comment.
+1 -- I'd always thought this was a DATA_INVARIANT(). It would certainly be Very Useful if it was.
There was a problem hiding this comment.
See #1843 regarding my investigations on this topic.
|
Obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise coverage goals cannot be linked to functions in consumers of CBMC output.