Skip to content

Travis: remove g++ build on OS X #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2018
Merged

Travis: remove g++ build on OS X #2209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,6 @@ jobs:
- COMPILER="ccache /usr/bin/g++-5"
- EXTRA_CXXFLAGS="-D_GLIBCXX_DEBUG"

# OS X using g++
- stage: Test different OS/CXX/Flags
os: osx
sudo: false
compiler: gcc
cache: ccache
before_install:
- HOMEBREW_NO_AUTO_UPDATE=1 brew install ccache parallel
- export PATH=$PATH:/usr/local/opt/ccache/libexec
env: COMPILER="ccache g++"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good idea, but I do note that the other build sets: EXTRA_CXXFLAGS="-Qunused-arguments -fcolor-diagnostics" and CCACHE_CPP2=yes - both of which should IMHO be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that for clang, you do really want CCACHE_CPP2=yes because of the way clang/llvm works, otherwise you get much poorer use of ccache. I haven't actually tested that myself though, so the world may well have moved on, but this http://peter.eisentraut.org/blog/2014/12/01/ccache-and-clang-part-3/ has some info and links to older info too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may (still) be true for Linux, but for the brew-provided ccache it seems to be set to yes/true by default anyway. Output on my Mac, no tweaks over the default config:

$ ccache -p | grep run_second_cpp
(default) run_second_cpp = true


# OS X using clang++
- stage: Test different OS/CXX/Flags
os: osx
Expand Down