Skip to content

Check all properties with property option #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions regression/cbmc/Multiple_Properties1/main.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
int main () {
int x, y;
__CPROVER_assume(x>=100 && y<=1000 & x>y+2);
x--;
assert(x>y);
x--;
assert(x>y);
x--;
assert(x>y);
y=0;
assert(x>y);

return 0;
}
10 changes: 10 additions & 0 deletions regression/cbmc/Multiple_Properties1/test.desc
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
CORE
main.c
--property main.assertion.1 --property main.assertion.3
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED
^.*main.assertion.1.*SUCCESS
^.*main.assertion.3.*FAILURE
--
^warning: ignoring
14 changes: 14 additions & 0 deletions regression/cbmc/Multiple_Properties2/main.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
int main () {
int x, y;
__CPROVER_assume(x>=100 && y<=1000 & x>y+2);
x--;
assert(x>y);
x--;
assert(x>y);
x--;
assert(x>y);
y=0;
assert(x>y);

return 0;
}
11 changes: 11 additions & 0 deletions regression/cbmc/Multiple_Properties2/test.desc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
CORE
main.c
--property main.assertion.1,main.assertion.3,main.assertion.4
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED
^.*main.assertion.1.*SUCCESS
^.*main.assertion.3.*FAILURE
^.*main.assertion.4.*SUCCESS
--
^warning: ignoring
14 changes: 14 additions & 0 deletions regression/cbmc/Multiple_Properties3/main.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
int main () {
int x, y;
__CPROVER_assume(x>=100 && y<=1000 & x>y+2);
x--;
assert(x>y);
x--;
assert(x>y);
x--;
assert(x>y);
y=0;
assert(x>y);

return 0;
}
9 changes: 9 additions & 0 deletions regression/cbmc/Multiple_Properties3/test.desc
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE
main.c
--property main.assertion.3
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED
^.*main.assertion.3.*FAILURE
--
^warning: ignoring
10 changes: 5 additions & 5 deletions src/cbmc/cbmc_parse_options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -181,16 +181,14 @@ void cbmc_parse_optionst::get_command_line_options(optionst &options)
options.set_option("simplify", true);

if(cmdline.isset("stop-on-fail") ||
cmdline.isset("property") ||
cmdline.isset("dimacs") ||
cmdline.isset("outfile"))
options.set_option("stop-on-fail", true);
else
options.set_option("stop-on-fail", false);

if(cmdline.isset("trace") ||
cmdline.isset("stop-on-fail") ||
cmdline.isset("property"))
cmdline.isset("stop-on-fail"))
options.set_option("trace", true);

if(cmdline.isset("localize-faults"))
Expand Down Expand Up @@ -595,10 +593,12 @@ bool cbmc_parse_optionst::set_properties(goto_functionst &goto_functions)
try
{
if(cmdline.isset("claim")) // will go away
::set_properties(goto_functions, cmdline.get_values("claim"));
::set_properties(goto_functions,
cmdline.get_comma_separated_values("claim"));

if(cmdline.isset("property")) // use this one
::set_properties(goto_functions, cmdline.get_values("property"));
::set_properties(goto_functions,
cmdline.get_comma_separated_values("property"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update code formatting.

}

catch(const char *e)
Expand Down
32 changes: 32 additions & 0 deletions src/util/cmdline.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,38 @@ const std::list<std::string>& cmdlinet::get_values(const std::string &option) co

/*******************************************************************\

Function: cmdlinet::get_comma_separated_values

Inputs:

Outputs:

Purpose:

\*******************************************************************/

const std::list<std::string> cmdlinet::get_comma_separated_values(
const std::string &option) const
{
int i=getoptnr(option);
assert(i>=0);
std::list<std::string> values;
for(const auto &value : options[i].values)
{
std::string::size_type length=value.length();
for(std::string::size_type idx=0; idx<length; idx++)
{
std::string::size_type next=value.find(",", idx);
values.push_back(value.substr(idx, next-idx));
if(next==std::string::npos) break;
idx=next;
}
}
return values;
}

/*******************************************************************\

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We meanwhile have split_string in util/string_utils.h merged, hence that function shouldn't be necessary anymore.

Function: cmdlinet::getoptnr

Inputs:
Expand Down
2 changes: 2 additions & 0 deletions src/util/cmdline.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ class cmdlinet

const std::list<std::string> &get_values(const std::string &option) const;
const std::list<std::string> &get_values(char option) const;
const std::list<std::string> get_comma_separated_values(
const std::string &option) const;

virtual bool isset(char option) const;
virtual bool isset(const char *option) const;
Expand Down