-
Notifications
You must be signed in to change notification settings - Fork 273
Added serialization of irept and dstringt #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
peterschrammel
merged 3 commits into
diffblue:security-scanner-support
from
NathanJPhillips:feature/serialization
Mar 23, 2017
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,33 @@ Author: Daniel Kroening, [email protected] | |
\*******************************************************************/ | ||
|
||
#include "dstring.h" | ||
#include "serializer.h" | ||
|
||
|
||
/*******************************************************************\ | ||
|
||
Function: dstring::serialize | ||
|
||
Inputs: | ||
serializer: The serializer to read from/write to | ||
|
||
Outputs: | ||
|
||
Purpose: | ||
Serializes this instance to/from the given serializer. | ||
|
||
\*******************************************************************/ | ||
void dstringt::serialize(serializert &serializer) | ||
{ | ||
if(serializer.is_for_reading()) | ||
{ | ||
std::string str; | ||
serializer.serialize("dstring", str); | ||
no=string_container[str]; | ||
} | ||
else | ||
{ | ||
std::string str=as_string(); | ||
serializer.serialize("dstring", str); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,9 @@ Author: Daniel Kroening, [email protected] | |
|
||
#include "string_container.h" | ||
|
||
class serializert; | ||
|
||
|
||
class dstringt | ||
{ | ||
public: | ||
|
@@ -123,6 +126,8 @@ class dstringt | |
return out << as_string(); | ||
} | ||
|
||
void serialize(serializert &serializer); | ||
|
||
// non-standard | ||
|
||
unsigned get_no() const | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ Author: Daniel Kroening, [email protected] | |
#include "string2int.h" | ||
#include "irep.h" | ||
#include "string_hash.h" | ||
#include "serializer.h" | ||
#include "irep_hash.h" | ||
|
||
#ifdef SUB_IS_LIST | ||
|
@@ -1003,3 +1004,24 @@ std::string irept::pretty(unsigned indent, unsigned max_indent) const | |
|
||
return result; | ||
} | ||
|
||
/*******************************************************************\ | ||
|
||
Function: irept::serialize | ||
|
||
Inputs: | ||
serializer: The serializer to read from/write to | ||
|
||
Outputs: | ||
|
||
Purpose: | ||
Serializes this instance to/from the given serializer. | ||
|
||
\*******************************************************************/ | ||
void irept::serialize(serializert &serializer) | ||
{ | ||
serializer.serialize("id", write().data); | ||
serializer.serialize("subs", get_sub()); | ||
serializer.serialize("named_subs", get_named_sub()); | ||
serializer.serialize("comments", get_comments()); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you making up new coding standards just to make things less structured/readable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One blank line should be enough to visually separate blocks. Two, three or more blank lines just stretch the code unnecessarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your argument sounds like it could be used to say we only need one type of header in documents. Different things need different levels of separation. I'll implement this because I'm giving up trying to make nice code on this project but I wish I could have made things better here.