fix: useSyncExternalStore backward compatibility #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
thoughts @pacocoursey? |
Contributor
Author
|
friendly ping @pacocoursey |
phsantiago
approved these changes
Aug 14, 2024
|
@phsantiago pls, merge this pr |
Contributor
Author
|
this is more for @pacocoursey |
pacocoursey
approved these changes
Oct 30, 2024
|
I think this might have broken some usages of cmdk on next15/react19. If I build from source without this pr everything works fine. This is what I am getting. |
|
same for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements retro-compatibility for
useSyncExternalStore. Hopefully with this PR and #165 we can usecmdkwithout issue in other React versions.