Skip to content

fix: attempt to prevent exceeding ResizeObserver loop limit #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pacocoursey merged 1 commit into from
Nov 24, 2022
Merged

fix: attempt to prevent exceeding ResizeObserver loop limit #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions cmdk/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,12 +738,18 @@ const List = React.forwardRef<HTMLDivElement, ListProps>((props, forwardedRef) =
if (height.current && ref.current) {
const el = height.current
const wrapper = ref.current
let animationFrame
const observer = new ResizeObserver(() => {
const height = el.getBoundingClientRect().height
wrapper.style.setProperty(`--cmdk-list-height`, height.toFixed(1) + 'px')
animationFrame = requestAnimationFrame(() => {
const height = el.getBoundingClientRect().height
wrapper.style.setProperty(`--cmdk-list-height`, height.toFixed(1) + 'px')
})
})
observer.observe(el)
return () => observer.unobserve(el)
return () => {
cancelAnimationFrame(animationFrame)
observer.unobserve(el)
}
}
}, [])

Expand Down