-
Notifications
You must be signed in to change notification settings - Fork 107
Sort all items in the tarball stats report #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to ensure that the testing is deterministic...
all items in the tarball stats report
all items in the tarball stats reportall items in the tarball stats report
all items in the tarball stats report
dbutenhof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first reaction is, "oh, no, another revlock" ... however, realistically, we need real configuration management which means everything is revlocked to not just a range but a specific version, preferably from a supported RPM. So, yeah. Cool. Third time's a charm?
|
Oops: Or, |
Yeah, well, adding the rev-lock actually has nothing to do with the problem I'm fixing...it's just that when I went to test my change, it suddenly failed in a new way...because, apparently, the build picked up a new version of the And this enabled me to see that the resulting sort comes out with the opposite order from what I expected, so I have yet another update with the fixed gold file. 😛 But, it looks good, now (modulo what LGTM comes up with...). |
|
The repo jinja2-humanize-extension is not so quiet... |
|
Hi @thebaptiste! Thanks for commenting here!! I apologize for my earlier comment -- clearly my doubts were misplaced: the fact that my issue had a single-digit number must be an indication of the quality of the work on (I'm quite amused by the fact that my referencing it in this repo added a mention on the Issue in your repo...it didn't occur to me that GitHub provides that level of integration. 😄) |
Currently, the v0.69 branch testing is failing due to a non-determinism in the
server/bin/pbench-tarball-stats.pyoutput. For parts of the report, the lists of servers are sorted; and, for other parts they are not. This change adds the missing sort directives to the output template.Fixes #2623.