Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 11, 2025

Backport of #12888 to release/13.0

/cc @JamesNK

Customer Impact

There are some bugs on the Azure provisioning dialog:

  • If the customer has Azure:SubscriptionId in their config then the Azure provisioning dialog is broken. Subscription locations are never loaded and can't be selected. Major impact.
  • If the customer doesn't have Azure:SubscriptionId in their config then the "Subscription Id" input is enabled before values are loaded into it by a tenant being selected. Minor impact.

Testing

Manual testing

Risk

Low

Regression?

Yes, this regressed in 13 when tenant selection was added to the dialog.

@github-actions
Copy link
Contributor Author

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12913

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12913"

@JamesNK JamesNK added the Servicing-consider Issue for next servicing release review label Nov 11, 2025
@JamesNK JamesNK requested a review from davidfowl November 11, 2025 23:58
@JamesNK JamesNK added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 11, 2025
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression and scoped fix. Approved. Should we add a test here too?

@joperezr joperezr added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 20, 2025
@joperezr joperezr merged commit 42ccc16 into release/13.0 Nov 21, 2025
296 checks passed
@joperezr joperezr deleted the backport/pr-12888-to-release/13.0 branch November 21, 2025 16:59
@joperezr
Copy link
Member

Discussed yesterday. Tests will be added in main.

This was referenced Dec 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages Re-opened Github-Action PR Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants