Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Aug 15, 2024

No description provided.

@wtgodbe wtgodbe requested a review from a team as a code owner August 15, 2024 00:02
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 15, 2024
@wtgodbe wtgodbe added this to the 10.0-preview1 milestone Aug 15, 2024
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<TieredCompilation>false</TieredCompilation>
<DefineConstants>$(DefineConstants);IS_BENCHMARKS</DefineConstants>
<SkipMicrobenchmarksValidation>true</SkipMicrobenchmarksValidation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The microbenchmark fails to find the just built SharedFx - this happens every time we update the branding/TFM in certain microbenchmarks, we're able to re-enable it once we get an SDK with the new TFM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Maybe add a comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner August 15, 2024 17:57
@wtgodbe
Copy link
Member Author

wtgodbe commented Aug 15, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants