JIT: Preserve overflow checks when folding scaled indexes - #133802
Open
EgorBo wants to merge 1 commit into
Open
Conversation
Fixes dotnet#133782 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5652b860-d333-435d-84bc-ad96d9d203e0
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A critical folding path can still discard a checked multiply and suppress the required OverflowException.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR addresses a CoreCLR JIT bug involving overflow checks during scaled-index folding.
Changes:
- Excludes checked multiplications from scaled-index folding.
- Adds regression coverage for operand order, integer types, and overflow behavior.
A critical issue remains: later folding paths can still discard checked multiplications and suppress OverflowException.
File summaries
| File | Reviewed change |
|---|---|
src/tests/JIT/Regression_ro_2/Runtime_133782.cs |
Adds regression tests for checked scaled multiplication and overflow behavior. |
src/coreclr/jit/gentree.cpp |
Prevents checked multiplications from scaled-index recognition, but later folding paths remain unguarded. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133782
Preserve checked multiplies during address-mode folding.