increase timeout on WebRequest timeout test #44612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl DetailsIssue meta data
|
Member
|
This change is fine, and it's great if it helps to eliminate instability in CI. However, even with a really small timeout specified, I don't see why the test should be failing. I'm skeptical there might be something else going on. |
stephentoub
approved these changes
Nov 12, 2020
Member
Author
|
ok, I can watch that. It fails pretty much only on Windows 7 and the test times out very quickly e.g. much sooner than the timeout value. |
Member
Author
|
I don't know if we had enough runs but so far there is no failure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increase timeout used in the Timeout_SetTenMillisecondsOnLoopback_ThrowsWebException test to be two of times quantum on Windows7. Since used time was shorter than precision of system timers, this test was not reliable.
fixes #44494