Add vulnerable option to telemetry #50739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zivkan
approved these changes
Sep 12, 2025
Member
zivkan
left a comment
There was a problem hiding this comment.
I don't know if this fits in the design for how the sdk team intend telemetry to be implemented. I think that LogVulnerableOptionForPackageUpdateCommand could be implemented as a rule that runs in the ParseResultLogRules foreach loop.
In any case, it looks like it should record the data that we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm largely following instructions from @zivkan relayed to him by @baronfel :D
The gist is that we want to know when customers run the update command, whether they used the
--vulnerableflag.