Skip to content

Conversation

@dead-horse
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

### Notable changes

* **feature**
* `runInBackground` use location as scope name when anonymous
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有点简单了吧,要写对 koa2 的支持,还有 async first,还有 8.x+ ?

然后升级指南要不要也写下?(我可以明天写写) 这个一发,oschina 等地方就会抓到了。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

升级指南单独写吧,这里面只记录了和上一个发布之间的差异

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对外的 codemod 还没搞定吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beta 版我感觉不应该算进去,大版本的话,应该是 2 个大版本之间的差异才好。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那等都搞定了才正式发?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

将前面的 beta changes log 合并一起写吧。

@atian25
Copy link
Member

atian25 commented Nov 20, 2017 via email

@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #1688 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1688   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          29       29           
  Lines         717      717           
=======================================
  Hits          714      714           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8197826...969953b. Read the comment docs.

@dead-horse
Copy link
Member Author

先合并到一起了,迁移指南到时候在文档中另写

@dead-horse
Copy link
Member Author

再看看

@atian25
Copy link
Member

atian25 commented Nov 21, 2017

+1

我正在写 migration.md

@dead-horse
Copy link
Member Author

这个先发?migrate 文档和工具估计还要不少时间

@atian25
Copy link
Member

atian25 commented Nov 21, 2017

@dead-horse dead-horse merged commit 37850d7 into master Nov 21, 2017
@dead-horse dead-horse deleted the release-2.0.0 branch November 21, 2017 03:07
@dead-horse
Copy link
Member Author

2.0.0 released !

popomore pushed a commit that referenced this pull request Nov 21, 2017
@fengmk2
Copy link
Member

fengmk2 commented Nov 21, 2017

@dead-horse 30% 的性能提升是否也写进去?

@atian25
Copy link
Member

atian25 commented Nov 21, 2017

写,最好写上,然后把 benchmark 地址加上

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants