Skip to content

Infosec ECLI-001: use npm ci #238

Description

@JoshMock

From Infosec's review of the codebase:

ECLI-001

CI uses npm install instead of npm ci — Medium

Problem

Three bare npm install calls in CI workflows should be npm ci to enforce lockfile integrity:

npm install can silently rewrite package-lock.json and resolves the latest versions matching each ^-range; npm ci uses the lockfile exactly and fails on drift.

Fix

Swap all three run: npm install lines to run: npm ci. Prioritize release.yml:45 — a non-reproducible install in the publish path is the most consequential of the three.

Risk

Medium. The release occurrence is the most consequential — npm install in the publish path can resolve a drifted (typosquatted or compromised) transitive dep and ship it to the registry before lockfile divergence is caught. The two CI occurrences are lower stakes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

securitySecurity related

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions