Skip to content

aws: track Amazon Inspector findings per namespace in vulnerability latest transform - #20427

Merged
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:aws-inspector-fix-transform
Jul 31, 2026
Merged

aws: track Amazon Inspector findings per namespace in vulnerability latest transform#20427
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:aws-inspector-fix-transform

Conversation

@kcreddy

@kcreddy kcreddy commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

aws: track Amazon Inspector findings per namespace in vulnerability latest transform

The Inspector vulnerability latest transform grouped only on
aws.inspector.transform_unique_id, so findings sharing a unique id across
different data_stream namespaces collapsed into a single latest document,
and findings from non-default namespaces could not be compared. Add
data_stream.namespace to the transform's unique key so findings are tracked
per namespace, matching the other CDR vulnerability transforms.

Adding a field to the unique key re-keys every destination document _id.
Since a fleet_transform_version bump reinstalls the transform but keeps the
existing destination index, the re-keyed documents would otherwise coexist
with the old-keyed ones under the vulnerability_latest alias for up to 90
days. Move the destination index to
security_solution-awsinspector.vulnerability_latest-v2 so the re-keyed
documents land in a clean index and the alias moves with it.

Bump fleet_transform_version to 0.4.0 so existing deployments delete and
reinstall the transform on upgrade.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

kcreddy added 2 commits July 31, 2026 17:06
…atest transform

The Inspector vulnerability latest transform grouped only on
aws.inspector.transform_unique_id, so findings sharing a unique id across
different data_stream namespaces collapsed into a single latest document,
and findings from non-default namespaces could not be compared. Add
data_stream.namespace to the transform's unique key so findings are tracked
per namespace, matching the other CDR vulnerability transforms.

Bump fleet_transform_version to 0.4.0 so existing deployments delete and
reinstall the transform on upgrade.
@kcreddy
kcreddy marked this pull request as ready for review July 31, 2026 11:37
@kcreddy
kcreddy requested review from a team as code owners July 31, 2026 11:37
@kcreddy kcreddy self-assigned this Jul 31, 2026
@kcreddy kcreddy added Integration:aws AWS Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 31, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy added the bugfix Pull request that fixes a bug issue label Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@vera-review-bot

Copy link
Copy Markdown

No issues across the latest commits 3de6edc.

Review summary

Issues found across earlier commits 1a71110 — 1 high
  • 🟠 Changing the latest transform's unique_key changes every destination document _id, but the existing destination index is kept on upgrade, so old-keyed documents linger as duplicates. Bump the destination index to -v2 alongside the fleet_transform_version bump. (link) (Unresolved)

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

cc @kcreddy

@kcreddy
kcreddy merged commit d3ca77f into elastic:main Jul 31, 2026
10 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package aws - 7.1.1 containing this change is available at https://epr.elastic.co/package/aws/7.1.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:aws AWS Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants