Skip to content

[Atlassian Confluence] Add condition support to Confluence Log File Integration - #7370

Merged
efd6 merged 2 commits into
elastic:mainfrom
BenB196:confluence-condition-support
Aug 21, 2023
Merged

[Atlassian Confluence] Add condition support to Confluence Log File Integration#7370
efd6 merged 2 commits into
elastic:mainfrom
BenB196:confluence-condition-support

Conversation

@BenB196

@BenB196 BenB196 commented Aug 13, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Enhancement - Adds support for setting condition to Atlassian Confluence Log File integration. This allows for defining this integration in a policy, but only having it run on during specific condition.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Install new version, confirm that condition field is available and can be set.

Related issues

Screenshots

image

@BenB196
BenB196 requested a review from a team as a code owner August 13, 2023 23:29
@elasticmachine

elasticmachine commented Aug 13, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-21T22:56:08.581+0000

  • Duration: 15 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same queries here as for the Jira change.

@efd6

efd6 commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.362
Classes 100.0% (3/3) 💚 3.362
Methods 100.0% (24/24) 💚 8.084
Lines 98.789% (408/413) 👍 10.46
Conditionals 100.0% (0/0) 💚

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
efd6 merged commit 83c4020 into elastic:main Aug 21, 2023
@elasticmachine

Copy link
Copy Markdown

Package atlassian_confluence - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=atlassian_confluence

@BenB196
BenB196 deleted the confluence-condition-support branch November 29, 2023 12:36
@andrewkroh andrewkroh added the Integration:atlassian_confluence Atlassian Confluence label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants