box_events: fingerprint the box.event_id field for doc deduplication - #9498
Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM. I assume this ID is unique across Box accounts (in case users are running multiple instances of the integration).
|
The text in the docs could be interpreted that way, "The ID of the event object. You can use this to detect duplicate events". The language is not quite strong enough for me to be completely happy. We could inject the client ID into the ingest pipeline for inclusion in the fingerprint set and then remove it. I think this would make me happier, though this value is per application, not per owner, so it may move.
I am unable to find a definitively documented identifier that we could use, so this is probably the best we have. |
kcreddy
left a comment
There was a problem hiding this comment.
I think this would make me happier, though this value is per application, not per owner, so it may move.
LGTM after adding client_id 👍🏼 although a test could be nice to have.
| - remove: | ||
| field: _conf.client_id | ||
| ignore_missing: true |
There was a problem hiding this comment.
Is this required since there is a remove on _conf field later in the pipeline?
|
💚 Build Succeeded
History
cc @efd6 |
|
Package box_events - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=box_events |

100.0% Coverage on New Code
0.0% Duplication on New Code
Proposed commit message
See https://developer.box.com/reference/resources/event/#param-event_id for field semantics.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots