feat(sync-service): Add function to dynamically re-enable consumer suspend #3548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3548 +/- ##
==========================================
+ Coverage 75.20% 75.35% +0.14%
==========================================
Files 51 51
Lines 2743 2743
Branches 404 404
==========================================
+ Hits 2063 2067 +4
+ Misses 678 674 -4
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robacourt
approved these changes
Dec 16, 2025
Contributor
robacourt
left a comment
There was a problem hiding this comment.
Nice! Just left a little nit
| disabled, because the configuration message will have the side-effect of | ||
| waking all consumers from hibernation. | ||
| The `max_timeout` value allows for spreading the suspension of existing |
Contributor
There was a problem hiding this comment.
It seems a bit confusing calling this a timeout, sure it's how it's implemented, but from an API perspective it's a max_stagger_delay and you'd probably do something like hibernate_after + Enum.random(0..max_stagger_delay)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM if you re-enable consumer suspend you don't gain much because existing, hibernated, consumers don't get the message (literally).
This ConsumerRegistry.enable_suspend/3 function is a single shot config plus consumer wake up call that we can use to sucessfully toggle suspension, mitigating the thundering herd effect.