feat: adds new storage v2 impl #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performance testing, it was found that write latencies linearly increase over time. I'm unable to find any O(n) in the commit code path, my working theory is that the file system operations slow down as the events directory increases in size. The standard@2 storage impl creates a 0-3 character sub-directory, acting as a bucket and reducing the number of event files stored the single events directory. The :bucket_length defaults to 2, and depending on the record name encoding this could vary in the number of buckets created. 256 for base16, 1024 for base32, or 4096 for base64url.
dc9fac8 to
5f4b86d
Compare
abaa1d5 to
b20c056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performance testing, it was found that write latencies linearly increase over time. I'm unable to find any O(n) in the commit code path, my working theory is that the file system operations slow down as the events directory increases in size.
The standard@2 storage impl creates a 0-3 character sub-directory, acting as a bucket and reducing the number of event files stored the single events directory.
The :bucket_length defaults to 2, and depending on the record name encoding this could vary in the number of buckets created. 256 for base16, 1024 for base32, or 4096 for base64url.