Skip to content

Update templates to use React 18 createRoot#12220

Merged
iansu merged 1 commit intofacebook:mainfrom
kyletsang:update-reactdom-render
Apr 8, 2022
Merged

Update templates to use React 18 createRoot#12220
iansu merged 1 commit intofacebook:mainfrom
kyletsang:update-reactdom-render

Conversation

@kyletsang
Copy link
Contributor

@kyletsang kyletsang commented Mar 30, 2022

Fixes #12219

Since CRA installs React 18 by default now, we should update the template to use the new createRoot

@kyletsang kyletsang requested review from iansu and mrmckeb as code owners March 30, 2022 04:36
@facebook-github-bot
Copy link

facebook-github-bot commented Mar 30, 2022

Hi @kyletsang!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 30, 2022

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@kyletsang kyletsang changed the title Update templates to use createRoot Update templates to use React 18 createRoot Apr 1, 2022
@tmshchk tmshchk mentioned this pull request Apr 1, 2022
Closed
jbenjoy2
jbenjoy2 reviewed Apr 3, 2022
View reviewed changes
packages/cra-template-typescript/template/src/index.tsx
import reportWebVitals from './reportWebVitals';

ReactDOM.render(
const root = ReactDOM.createRoot(
Copy link

@jbenjoy2 jbenjoy2 Apr 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im also getting warnings in the default app.test.js file since it uses the render method from react testing library. Not sure if that needs a similar fix but in case you know better than i do i thought i'd point it out. Thanks so much for this PR i think it'll be really crucial going forward

Copy link
Contributor Author

@kyletsang kyletsang Apr 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jbenjoy2, the RTL changes will be done with #12223

@kyletsang kyletsang mentioned this pull request Apr 4, 2022
Closed
@minimabot minimabot mentioned this pull request Apr 8, 2022
Closed
@kyletsang kyletsang force-pushed the update-reactdom-render branch from 5f2dc08 to b5288ec Compare April 8, 2022 17:15
@rickhanlonii
Copy link
Member

rickhanlonii commented Apr 8, 2022

Hey just checking in, what's blocking this?

@kyletsang
Copy link
Contributor Author

kyletsang commented Apr 8, 2022

Friendly ping @iansu and @mrmckeb. This PR is ready to merge.

@iansu
Copy link
Contributor

iansu commented Apr 8, 2022

Now that the TypeScript types for React 18 are out nothing is blocking this. Does this need to be merged along with #12223?

@kyletsang
Copy link
Contributor Author

kyletsang commented Apr 8, 2022

Now that the TypeScript types for React 18 are out nothing is blocking this. Does this need to be merged along with #12223?

Yes, the RTL update should also be merged for react 18 compatibility.

Thanks!

@iansu
Copy link
Contributor

iansu commented Apr 8, 2022

@kyletsang I merged the RTL PR. Do you mind updating this branch from main so we can re-run the tests?

@iansu iansu added this to the 5.0.1 milestone Apr 8, 2022
@kyletsang kyletsang force-pushed the update-reactdom-render branch from b5288ec to d9ae406 Compare April 8, 2022 20:57
@kyletsang
Copy link
Contributor Author

kyletsang commented Apr 8, 2022

@iansu done!

@iansu iansu merged commit 2eef1d0 into facebook:main Apr 8, 2022
@iansu
Copy link
Contributor

iansu commented Apr 8, 2022

Thanks!

@kyletsang kyletsang deleted the update-reactdom-render branch April 8, 2022 22:05
@void0err
Copy link

void0err commented Apr 10, 2022

At which version, is this going to fix?

As far today(April 10th, 2022), the npx create-react-app doesn't pickup this change.

@icecream17 icecream17 mentioned this pull request Apr 12, 2022
Closed
1 task
This was referenced Apr 13, 2022
Closed
Closed
@sapphi-red sapphi-red mentioned this pull request Apr 25, 2022
Merged
9 tasks
aruniverse pushed a commit to imodeljs/create-react-app that referenced this pull request Sep 6, 2022
@kyletsang @aruniverse
Update templates to use React 18 createRoot (facebook#12220)
d46f798
@chohannah chohannah mentioned this pull request Sep 15, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Sep 15, 2024
Open
@b4nng b4nng mentioned this pull request Sep 17, 2024
Open
@chohannah chohannah mentioned this pull request Sep 17, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Sep 17, 2024
Open
@b4nng b4nng mentioned this pull request Sep 18, 2024
Open
@chohannah chohannah mentioned this pull request Sep 18, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Sep 18, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Sep 19, 2024
Open
@chohannah chohannah mentioned this pull request Sep 19, 2024
Open
@b4nng b4nng mentioned this pull request Sep 19, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Sep 19, 2024
Open
@chohannah chohannah mentioned this pull request Sep 20, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Sep 20, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Sep 21, 2024
Open
@chohannah chohannah mentioned this pull request Sep 21, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@b4nng b4nng mentioned this pull request Sep 22, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Sep 22, 2024
Open
@fredyvaron fredyvaron mentioned this pull request Sep 23, 2024
Open
@Hiranyape Hiranyape mentioned this pull request Sep 27, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 23, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 31, 2024
Open
@barunslick barunslick mentioned this pull request Oct 31, 2024
Open
@GregBrimble GregBrimble mentioned this pull request Nov 8, 2024
Open
@fossabot fossabot bot mentioned this pull request Aug 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

1 more reviewer

@jbenjoy2 jbenjoy2 jbenjoy2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed tag: enhancement

Projects

None yet

Milestone

5.0.1

Development

Successfully merging this pull request may close these issues.

Browser console warning about React 18 and ReactDOM.render

6 participants

@kyletsang @facebook-github-bot @rickhanlonii @iansu @void0err @jbenjoy2