Allow testMatch for jest config#9114
Allow testMatch for jest config#9114ianschmitz merged 1 commit intofacebook:masterfrom favna:feat/react-scripts/allow-testmatch
Conversation
|
Hi @favna! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Failing CI appears unrelated to this PR, as a matter of fact, at time of writing CI is also failing on master.... |
mrmckeb
left a comment
There was a problem hiding this comment.
I see no reason why this would affect the CI either, sorry you hit that issue.
@ianschmitz I think we can merge this one?
|
Bah this error in CI is getting old... |
Resolves #8637.
Tested locally with these steps:
cd packages/react-scriptsyarn linkyarn link "react-scripts"SKIP_PREFLIGHT_CHECKS=true yarn testtestMatchkey topackage.jsonJest configSKIP_PREFLIGHT_CHECKS=true yarn testagainFor further reasoning as to why this option should be added please refer to #8637.