fix(dev-server): use correct dev server HTML lang attribute #11271
Conversation
|
Hi @enumura1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
slorber
left a comment
There was a problem hiding this comment.
LGTM thanks
Just did a minor change since the locale name can be anything and may not be a BCP47 locale
Pre-flight checklist
Motivation
This fixes a bug where the development server always uses
lang="en"in HTML regardless of the configuredi18n.defaultLocale.Test Plan
i18n.defaultLocale: 'ja'npm start<html lang="en">- causing browser translation popups<html lang="ja">- no inappropriate popupsBefore
After
Test links
Deploy preview: https://deploy-preview-11271--docusaurus-2.netlify.app/
Related issues/PRs
fix #11253