[standards] Migrate vendored code from Haste to path-based imports#24807
Closed
ide wants to merge 1 commit intofacebook:masterfrom
Closed
[standards] Migrate vendored code from Haste to path-based imports#24807ide wants to merge 1 commit intofacebook:masterfrom
ide wants to merge 1 commit intofacebook:masterfrom
Conversation
This is the next step in moving RN towards standard path-based requires. All the requires in `Libraries/vendor` have been rewritten to use relative requires. Talking to cpojer, the vendored code in RN can be modified directly. This commit uses relative requires instead of `react-native/...` so that if Facebook were to stop syncing out certain folders and therefore remove code from the react-native package, internal code at Facebook would not need to change. Test Plan: Prettier/Lint, Flow, Jest tests, loaded RNTester
Closed
12 tasks
facebook-github-bot
approved these changes
May 13, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @ide in 346417c. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the next step in moving RN towards standard path-based requires. All the requires in
Libraries/vendorhave been rewritten to use relative requires. Talking to cpojer, the vendored code in RN can be modified directly.This commit uses relative requires instead of
react-native/...so that if Facebook were to stop syncing out certain folders and therefore remove code from the react-native package, internal code at Facebook would not need to change.Closes #24769.
Changelog
[General] [Changed] - Migrate vendored code from Haste to path-based imports
Test Plan
Test Plan: Prettier/Lint, Flow, Jest tests, loaded RNTester