chore: stricter TS check for transform style

[vonovak]

Summary:

This improves the strictness of TS typings for transform on View's style prop. Consider the following example, with what TS reports in case of errors, using RN 0.72.3. The ❌ / ✅ symbols indicate whether TS is happy with the code

❌ <View style={{ transform: [{ scale: undefined }] }} />              //  TS2769: No overload matches this call. 
❌ <View style={{ transform: [{ something: 1 }] }} />                  //  TS2769: No overload matches this call.
✅ <View style={{ transform: [{ scale: 1 }, { rotate: '90deg' }] }} />
✅ <View style={{ transform: [{ scale: 1, translateX: 1 }] }} /> // this is WRONG, corrected in the next row
✅ <View style={{ transform: [{ scale: 1 }, { translateX: 1 }] }} />

With this change, TS will report an error even for line 4

❌ <View style={{ transform: [{ scale: undefined }] }} />              //  TS2769: No overload matches this call. 
❌ <View style={{ transform: [{ something: 1 }] }} />                  //  TS2769: No overload matches this call.
✅ <View style={{ transform: [{ scale: 1 }, { rotate: '90deg' }] }} />
❌ <View style={{ transform: [{ scale: 1, translateX: 1 }] }} />      //  TS2769: No overload matches this call.
✅ <View style={{ transform: [{ scale: 1 }, { translateX: 1 }] }} />

Changelog:

Test Plan:

tested locally with the example given above; also added a TS type test

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,834,261	-65
android	hermes	armeabi-v7a	8,143,547	-9
android	hermes	x86	9,338,645	+45
android	hermes	x86_64	9,181,669	+39
android	jsc	arm64-v8a	9,446,930	-1
android	jsc	armeabi-v7a	8,628,558	-1
android	jsc	x86	9,529,024	-1
android	jsc	x86_64	9,772,803	-1

Base commit: 06668fc
Branch: main

[facebook-github-bot]

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@NickGerleman merged this pull request in e414713.

[NickGerleman]

@vonovak from #41869 it looks like this change may cause typechecking issues when not using TS strict mode.

(After the holidays) we will probably want to look at fixing this, or potentially reverting the change, since RN typings should support users not on strict mode.

[NickGerleman]

Hmm, I learned that DefinitelyTyped itself checks with strictNullChecks, and that our own type tests model that, and are clean with this change. https://github.com/facebook/react-native/blob/main/packages/react-native/types/tsconfig.json

I think it DT only checks against strictNullChecks, we should require it as well.