-
Notifications
You must be signed in to change notification settings - Fork 424
feat: detect mic-using apps for hooks app_meeting parameter #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add get_meeting_app() function in crates/detect to detect Zoom/Teams/Webex - Add MEETING_APP_BUNDLE_IDS constant for meeting app detection - Add getMeetingApplication command in plugins/detect - Update listener store to populate app_meeting in hooks with detected meeting app - Focus on macOS implementation as requested Co-Authored-By: yujonglee <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: yujonglee <[email protected]>
|
Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it. |
3 similar comments
|
Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it. |
|
Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it. |
|
Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it. |
cd99174 to
cb527d5
Compare
Summary
Implements detection of apps using the microphone for the
--app-meetinghook parameter. When hooks (beforeListeningStartedandafterListeningStopped) are triggered, the system now detects which app is using the microphone and passes the app name instead ofnull.Changes:
get_meeting_app()function incrates/detectthat returns the first app currently using the microphonegetMeetingApplicationTauri command exposed to frontendapp_meetingin hook argsApproach: Rather than filtering against a hardcoded list of meeting app bundle IDs, the function returns any app using the microphone. This is more flexible and handles browser-based meetings, lesser-known meeting apps, and various browsers.
Linux returns
Nonefor now (stub implementation).Updates since last revision
Removed the hardcoded
MEETING_APP_BUNDLE_IDSfilter (Zoom, Teams, Webex). Nowget_meeting_app()simply returns the first app using the microphone vialist_mic_using_apps().into_iter().next(). This addresses feedback that the 3-platform constraint was not flexible enough for browser-based meetings and other meeting apps.Review & Testing Checklist for Human
app_meetingapp_meetingapp_meetingisnullRecommended test plan:
app_meetingparameterNotes
list_mic_using_apps()infrastructure which queries Core Audioget_meeting_appis kept for API consistency, though it now returns any mic-using appLink to Devin run: https://app.devin.ai/sessions/54788bc52c354b56a9047d4612626525
Requested by: @yujonglee