Skip to content

Override ResponseJson::MarkFailed to set application_data_. #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 5, 2021
Merged

Override ResponseJson::MarkFailed to set application_data_. #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d20fc7
Don't try to access error_code if application_data is null.
jonsimantov Nov 5, 2021
e60a5f2
Revert "Don't try to access error_code if application_data is null."
jonsimantov Nov 5, 2021
93e64b8
Override ResponseJson::MarkFailed so that it sets application_data_.
jonsimantov Nov 5, 2021
f477a9d
Release note for bugfix
jonsimantov Nov 5, 2021
4dc5c31
Remove tabs
jonsimantov Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/rest/response_json.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ class ResponseJson : public Response {
Response::MarkCompleted();
}

// When the response fails, ensure that application_data_ is set.
void MarkFailed() override {
application_data_.reset(new FbsTypeT());
Response::MarkFailed();
}

protected:
// The FlatBuffer parser used to parse the response JSON string.
flatbuffers::unique_ptr<flatbuffers::Parser> parser_;
Expand Down
8 changes: 7 additions & 1 deletion release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,12 @@ workflow use only during the development of your app, not for publicly shipping
code.

## Release Notes
### Next Release
- Changes
- Auth (Desktop): Fixed a crash in `error_code()` when a request
is cancelled or times out.
([#737](https://github.com/firebase/firebase-cpp-sdk/issues/737))

### 8.7.0
- Changes
- Firestore: Released to general availability for Android and iOS (desktop
Expand Down Expand Up @@ -666,7 +672,7 @@ code.
([#429](https://github.com/firebase/firebase-cpp-sdk/pull/429)).
- AdMob (iOS): Temporarily pinned AdMob dependency to a special version of the
Google-Mobile-Ads-SDK Cocoapod, "7.69.0-cppsdk", to maintain compatibility
with version 8.x of the Firebase iOS SDK.
with version 8.x of the Firebase iOS SDK.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untabified the file.

- General (iOS): A Database URL is no longer required to be present in
GoogleService-Info.plist when not using the Real Time Database.
- Firestore: Added `Firestore::LoadBundle` to enable loading Firestore Data
Expand Down