Fix race condition by capturing version in goroutine #855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is related to a race condition when using the
versionToUsevariable in concurrent goroutines:Problem Description
At line 246 (
versionToUse = GetPayloadV1), a local variableversionToUseis modified, which is captured by the closure of all running goroutines (lines 159-314). This leads to the following issue:versionToUse == GetPayloadV2versionToUse = GetPayloadV1(line 246)StatusCode == 202 (Accepted)if versionToUse == GetPayloadV1(line 266)Technical Details
All goroutines share a single
versionToUsevariable captured through closure. When one goroutine modifies its value (line 246), it immediately affects the processing logic in other goroutines (lines 266-302), which may be at different execution stages.Consequences