This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[connectivity] Migrate more logic to method channel platform#2526
Merged
ditman merged 11 commits intoflutter:masterfrom Feb 14, 2020
Merged
[connectivity] Migrate more logic to method channel platform#2526ditman merged 11 commits intoflutter:masterfrom
ditman merged 11 commits intoflutter:masterfrom
Conversation
…plementation. connectivity_platform_interface: * Bring ConnectivityResult and LocationAuthorizationStatus enums from core package. * Use the above Enums as return values for ConnectivityPlatformInterface methods. * Modify the MethodChannel implementation so it returns the right types. * Bring utility methods, asserts and other logic that is only needed on the MethodChannel implementation from the core package, so it's simpler. * Bring MethodChannel unit tests from core package. connectivity (core pkg): * Reexport ConnectivityResult and LocationAuthorizationStatus enums so plugin users can see them. * Remove MethodChannel unit tests (moved to platform_interface).
Contributor
Author
|
Mostly @ditman work, but happy to take the credit :) |
Member
|
@franciscojma86 you can't push changes to two packages at the same time, because our testing won't know what you do. You first need to PR and release the changes to the |
ditman
suggested changes
Feb 13, 2020
Member
ditman
left a comment
There was a problem hiding this comment.
Please, remove changes from the core connectivity package, so this PR just changes the connectivity_platform_interface package.
ditman
approved these changes
Feb 14, 2020
| }) { | ||
| // `assert(Platform.isIOS)` will prevent us from doing dart side unit testing. | ||
| // TODO: These should noop for non-Android, instead of throwing, so people don't need to rely on dart:io for this. | ||
| assert(!Platform.isAndroid); |
Member
There was a problem hiding this comment.
I thought about this a little bit, and we need to remove these Platform asserts, they don't add anything to this plugin (other than a dependency in dart:io).
We can do this in other PR, though.
Contributor
Author
There was a problem hiding this comment.
Yeah I thought so too, but I think the first changes I'd like to keep the API as similar as possible to the current behavior.
sanekyy
pushed a commit
to sanekyy/plugins
that referenced
this pull request
Feb 18, 2020
…from the core package (flutter#2526) * Bring ConnectivityResult and LocationAuthorizationStatus enums from core package. * Use the above Enums as return values for ConnectivityPlatformInterface methods. * Modify the MethodChannel implementation so it returns the right types. * Bring utility methods, asserts and other logic that is only needed on the MethodChannel implementation from the core package, so it's simpler. * Bring MethodChannel unit tests from core package. Co-authored-by: David Iglesias <ditman@gmail.com>
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…from the core package (flutter#2526) * Bring ConnectivityResult and LocationAuthorizationStatus enums from core package. * Use the above Enums as return values for ConnectivityPlatformInterface methods. * Modify the MethodChannel implementation so it returns the right types. * Bring utility methods, asserts and other logic that is only needed on the MethodChannel implementation from the core package, so it's simpler. * Bring MethodChannel unit tests from core package. Co-authored-by: David Iglesias <ditman@gmail.com>
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…from the core package (flutter#2526) * Bring ConnectivityResult and LocationAuthorizationStatus enums from core package. * Use the above Enums as return values for ConnectivityPlatformInterface methods. * Modify the MethodChannel implementation so it returns the right types. * Bring utility methods, asserts and other logic that is only needed on the MethodChannel implementation from the core package, so it's simpler. * Bring MethodChannel unit tests from core package. Co-authored-by: David Iglesias <ditman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An improvement over the current platform_interface implementation, migrating more logic into the method channel platform.
Related Issues
flutter/flutter#46307
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?