Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@creativecreatorormaybenot
Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot commented Jun 2, 2021

cc @Hixie @stuartmorgan I explained here why a breaking change was handled inproperly and this is why we need to specify the dependency that is at least 2.0.3.

Before that version, the method head of pushRouteNameToFramework was different, which means that ^2.0.0 for the platform interface is a lie - any version before 2.0.3 is incompatible.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix here is correct (there's an alternate option of making this actually backward compatible down to 2.0.0 again by changing the function variable type, but getting more people onto url_launcher_platform_interface 2.0.3 is a better outcome since 2.0.0-2 don't work correctly with master), but the description in the PR and the CHANGELOG are not, per #3954 (comment), unless I've missed something.

@creativecreatorormaybenot
Copy link
Contributor Author

@stuartmorgan So you think this PR would be fine to merge if the CHANGELOG was amended. If so, what would you include in the changelog / how would you phrase it?

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rewritten the changelog; LGTM with that. Thanks for finding this!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 2, 2021
@creativecreatorormaybenot
Copy link
Contributor Author

@stuartmorgan Thanks a lot ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes p: url_launcher waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants