Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Initial proof of concept implementation of flutter_webview for the web.

This is #4565 with the following changes:

  • Fixes unit test compilation on master
  • Adds very minimal integration tests

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-web labels Dec 7, 2021
@stuartmorgan-g stuartmorgan-g requested a review from ditman December 7, 2021 21:03
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically the same as #4565, but with a small fix to Mocks and a couple of new tests added by @stuartmorgan.

:shipit:

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 8, 2021
@a-eniou-pvotal
Copy link

@stuartmorgan As I can see, WebViewPlatformController is not supported, I wonder if it will be in the next release?
https://github.com/flutter/plugins/blob/master/packages/webview_flutter/webview_flutter_web/lib/webview_flutter_web.dart

@stuartmorgan-g
Copy link
Contributor Author

@stuartmorgan As I can see, WebViewPlatformController is not supported

I don't know what that means, given that you provided a link to a file that implements it. But if you have bugs or feature requests for the package, please use the issue tracker as always.

@a-eniou-pvotal
Copy link

@stuartmorgan I mean most of functions throw UnimplementedError();
Ok I will use issue trackers in the future

amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
Initial proof of concept implementation of flutter_webview for the web.
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Initial proof of concept implementation of flutter_webview for the web.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p: webview_flutter Edits files for a webview_flutter plugin platform-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants