Add Google Search App support #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@fnando The build seems to be failing because of Rubocop, but I can't reproduce it locally (and it seems to be complaining about the files that I haven't changed as part of this PR). |
Owner
|
@milandobrota just pushed latest Rubocop fixes to master. Can you please rebase? |
33da24f to
552bc29
Compare
552bc29 to
19982e4
Compare
Contributor
Author
|
@fnando Hey it looks like we pushed at the same time. :) |
Contributor
Author
|
@fnando It looks like it passed anyway. :) |
Owner
|
@milandobrota yeah, sorry for tainting your branch. I have some time to work on this right now, and didn't want to wait. :O |
Owner
|
Thanks for this pull request! :) |
Contributor
Author
|
No problem! |
fnando
pushed a commit
that referenced
this pull request
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.