Bugfixes #271
Open
Bugfixes #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception in thread "main" java.lang.NullPointerException at cz.startnet.utils.pgdiff.parsers.CreateRuleParser.parse(CreateRuleParser.java:74) at cz.startnet.utils.pgdiff.loader.PgDumpLoader.loadDatabaseSchema(PgDumpLoader.java:275) at cz.startnet.utils.pgdiff.loader.PgDumpLoader.loadDatabaseSchema(PgDumpLoader.java:311) at cz.startnet.utils.pgdiff.PgDiff.createDiff(PgDiff.java:35) at cz.startnet.utils.pgdiff.Main.main(Main.java:39) when rule was not in default schema (because of incorrect lookup).
Fix incorrect disable trigger parsing of quoted identifiers. Fix incorrect expectOptional implementation not adhering to documented behavior.
Also fix a case that was failing in tests, with some weird code. The fix maybe isn't the nicest either, but at least better than previously.
jalissonmello
pushed a commit
to jalissonmello/apgdiff
that referenced
this pull request
May 10, 2020
Error on disable/enable trigger on trigger that dont exists on old schema. Copy corrections from: Support Postgresql 12 - Fix incorrect disable trigger parsing of quoted identifiers. Bugfixes fordfrog#271 marcus-kempe fix for null pointer exception fordfrog#270 marco44 Fix issue where rule parsing was throwing # 269-marcus-kempe fixed some crashes fordfrog#257 d1maxa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for slony truncate triggers.
Fix incorrect disable trigger parsing of quoted identifiers.
Fix incorrect expectOptional implementation not adhering to documented behavior.