Skip to content

[decimal] Implement true_divide for BigDecimal type + fix a bug in BigUInt.multiply #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2025
Merged

[decimal] Implement true_divide for BigDecimal type + fix a bug in BigUInt.multiply #70

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b84294
Almost there
forfudan Mar 29, 2025
5972e7a
Add bench
forfudan Mar 29, 2025
db447e3
Finish div for BigDec
forfudan Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Finish div for BigDec
  • Loading branch information
@forfudan
forfudan committed Mar 30, 2025
commit db447e300e0bc1513c54ff7ab401a09296cc4faa
4 changes: 0 additions & 4 deletions src/decimojo/biguint/arithmetics.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,6 @@ fn multiply(x1: BigUInt, x2: BigUInt) raises -> BigUInt:
carry = UInt64(0)

for j in range(len(x2.words)):
# Skip if the word is zero
if x2.words[j] == 0:
continue

# Calculate the product of the current words
# plus the carry from the previous multiplication
# plus the value already at this position in the result
Expand Down
Loading