[decimojo] Improve the division operation for BigDecimal and others
#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forfudan
added a commit
that referenced
this pull request
Mar 31, 2025
…71) This pull request includes several important updates to the `decimojo` project, including documentation enhancements, dependency adjustments, and improvements to arithmetic operations. The most significant changes are summarized below: * [`README.md`](diffhunk://#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L5-R5): Added a link to the changelog for better navigation. * [`docs/changelog.md`](diffhunk://#diff-77f023b99d3d58008351d3e82fc06e6d06ba1bc2da9e41be6329b7fa4f419f05L1-R3): Updated to include a link to the unreleased changes. * [`docs/changelog_unreleased.md`](diffhunk://#diff-fbe2a82b558eb11e93dded341697980acc701ce3004ca9933632af801e98f8cbR1-R11): Created a new file to track unreleased changes, including new features and bug fixes. * [`mojoproject.toml`](diffhunk://#diff-1b0ef62120bccf4c05a76e60e13fe686f33eb92d5897b3f05e0c3f8d737fc5c0L13-R13): Changed the version constraint for the `max` dependency from `>=25.2` to `==25.2` to ensure compatibility. * [`src/decimojo/bigdecimal/arithmetics.mojo`](diffhunk://#diff-f79534f4e7fdd891932ce9d015c50bd3c8a72c4a1689f0cb55524490ffc0458dR191-R216): Enhanced the `true_divide` function by optimizing precision handling and improving the rounding mechanism. [[1]](diffhunk://#diff-f79534f4e7fdd891932ce9d015c50bd3c8a72c4a1689f0cb55524490ffc0458dR191-R216) [[2]](diffhunk://#diff-f79534f4e7fdd891932ce9d015c50bd3c8a72c4a1689f0cb55524490ffc0458dL224-R307) [[3]](diffhunk://#diff-f79534f4e7fdd891932ce9d015c50bd3c8a72c4a1689f0cb55524490ffc0458dL315-R329) * [`src/decimojo/bigdecimal/bigdecimal.mojo`](diffhunk://#diff-be2f9b2702fd15952546e17fe94a64c22902a0e4678bfd9cb925269647923db4L301-R362): Updated the `to_string` method to support scientific notation and added a new `true_divide` method for precision control. [[1]](diffhunk://#diff-be2f9b2702fd15952546e17fe94a64c22902a0e4678bfd9cb925269647923db4L301-R362) [[2]](diffhunk://#diff-be2f9b2702fd15952546e17fe94a64c22902a0e4678bfd9cb925269647923db4R389) [[3]](diffhunk://#diff-be2f9b2702fd15952546e17fe94a64c22902a0e4678bfd9cb925269647923db4R462-R489) * [`src/decimojo/biguint/arithmetics.mojo`](diffhunk://#diff-95a5c66e5957fff2a2a8a2710ffb11a4ad7d0bddaf3bc11d075d62ddaa8b915cL1017-R1018): Fixed a bug in `scale_down_by_power_of_10` function to handle zero shifts correctly. * [`src/decimojo/biguint/biguint.mojo`](diffhunk://#diff-f9432b9b2671643af91201f9e3f011551a3d3b0e6d7b256d0d4569f5ae59848aL855-R867): Improved the `ith_digit` method with additional error handling and added a new `number_of_digits` method. [[1]](diffhunk://#diff-f9432b9b2671643af91201f9e3f011551a3d3b0e6d7b256d0d4569f5ae59848aL855-R867) [[2]](diffhunk://#diff-f9432b9b2671643af91201f9e3f011551a3d3b0e6d7b256d0d4569f5ae59848aR883-R900) These changes collectively enhance the functionality, reliability, and documentation of the `decimojo` library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several important updates to the
decimojoproject, including documentation enhancements, dependency adjustments, and improvements to arithmetic operations. The most significant changes are summarized below:Documentation Enhancements:
README.md: Added a link to the changelog for better navigation.docs/changelog.md: Updated to include a link to the unreleased changes.docs/changelog_unreleased.md: Created a new file to track unreleased changes, including new features and bug fixes.Dependency Adjustments:
mojoproject.toml: Changed the version constraint for themaxdependency from>=25.2to==25.2to ensure compatibility.Arithmetic Operations Improvements:
src/decimojo/bigdecimal/arithmetics.mojo: Enhanced thetrue_dividefunction by optimizing precision handling and improving the rounding mechanism. [1] [2] [3]src/decimojo/bigdecimal/bigdecimal.mojo: Updated theto_stringmethod to support scientific notation and added a newtrue_dividemethod for precision control. [1] [2] [3]Bug Fixes:
src/decimojo/biguint/arithmetics.mojo: Fixed a bug inscale_down_by_power_of_10function to handle zero shifts correctly.src/decimojo/biguint/biguint.mojo: Improved theith_digitmethod with additional error handling and added a newnumber_of_digitsmethod. [1] [2]These changes collectively enhance the functionality, reliability, and documentation of the
decimojolibrary.