Skip to content

fix: create env on append in /update handler #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonypzy wants to merge 3 commits into
base: dev
Choose a base branch
from
+3 −0
Open

fix: create env on append in /update handler #1373

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbda0c5
Add checking for eid
tonypzy Jun 3, 2026
4b167c7
Merge branch 'dev' into fix/775-update-append-new-env
tonypzy Jun 7, 2026
340519e
Merge branch 'dev' into fix/775-update-append-new-env
tonypzy Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions py/visdom/server/handlers/web_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@ def update(p, args, max_text_lines, max_old_content, max_image_history):
def wrap_func(handler, args):
eid = extract_eid(args)

if eid not in handler.state:
handler.state[eid] = {"jsons": {}, "reload": {}}
Comment thread
tonypzy marked this conversation as resolved.
Comment thread
tonypzy marked this conversation as resolved.

if args["win"] not in handler.state[eid]["jsons"]:
# Append to a window that doesn't exist attempts to create
# that window
Expand Down
Loading