-
Notifications
You must be signed in to change notification settings - Fork 12k
A simple script merge lora to HF #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Script merge lora to HF
Fix editorconfig-checker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add program and argument descriptions the
ArgumentParser
- Remove the default argument values and set them as required instead (for the model, you could also default it to something like
decapoda-research/llama-7b-hf
) - Rename the file to something more descriptive
- Improve code formatting (you can use an auto-format tool such as black)
- Remove unused imports
Thank you for the advice, gonna fix then, but... what do you mean by "Add program and argument descriptions the |
Just add a short description of what the program and each argument do (you can see how to that in the documentation). |
Co-authored-by: slaren <[email protected]>
Co-authored-by: slaren <[email protected]>
This works pretty well. I think there should be a mention somewhere that it adds more required pip packages. I don't know if we should put them in the |
No clue, but I assume they would like to open that script while they are working on it🤦 |
Thanks for #1516
I hope your guys enjoy it.