Skip to content

A simple script merge lora to HF #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

A simple script merge lora to HF #1531

wants to merge 14 commits into from

Conversation

FNsi
Copy link
Contributor

@FNsi FNsi commented May 20, 2023

Thanks for #1516
I hope your guys enjoy it.

FNsi added 2 commits May 20, 2023 08:18
@FNsi FNsi changed the title A simple script merge lora A simple script merge lora to HF May 20, 2023
Fix editorconfig-checker
Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add program and argument descriptions the ArgumentParser
  • Remove the default argument values and set them as required instead (for the model, you could also default it to something like decapoda-research/llama-7b-hf)
  • Rename the file to something more descriptive
  • Improve code formatting (you can use an auto-format tool such as black)
  • Remove unused imports

@FNsi
Copy link
Contributor Author

FNsi commented May 21, 2023

  • Add program and argument descriptions the ArgumentParser

  • Remove the default argument values and set them as required instead (for the model, you could also default it to something like decapoda-research/llama-7b-hf)

  • Rename the file to something more descriptive

  • Improve code formatting (you can use an auto-format tool such as black)

  • Remove unused imports

Thank you for the advice, gonna fix then, but... what do you mean by "Add program and argument descriptions the ArgumentParser" ?
Should I write some notes or?

@slaren
Copy link
Member

slaren commented May 21, 2023

Just add a short description of what the program and each argument do (you can see how to that in the documentation).

@SlyEcho
Copy link
Collaborator

SlyEcho commented May 24, 2023

This works pretty well.

I think there should be a mention somewhere that it adds more required pip packages. I don't know if we should put them in the requirements.txt or not.

@FNsi
Copy link
Contributor Author

FNsi commented May 25, 2023

No clue, but I assume they would like to open that script while they are working on it🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants