Skip to content

fix: add generic fallback to detect trailing <think> tags in Jinja templates and handle forced-open reasoning blocks #16426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+131 −8
Draft

fix: add generic fallback to detect trailing <think> tags in Jinja templates and handle forced-open reasoning blocks #16426

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b47a58
fix: add generic fallback to detect trailing <think> tags in Jinja te…
ServeurpersoCom Oct 4, 2025
ba34160
fix: track supports_enable_thinking in chat templates and propagate i…
ServeurpersoCom Oct 6, 2025
6041e25
chat-parser: address pr-16394 review feedback from ngxson
ServeurpersoCom Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chat-parser: address pr-16394 review feedback from ngxson 
Co-authored-by: Xuan Son Nguyen <[email protected]>
  • Loading branch information
@ServeurpersoCom @ngxson
ServeurpersoCom and ngxson committed Oct 6, 2025
commit 6041e2562fd4a47f4aa47a0a22af12f1ea752dbb
4 changes: 0 additions & 4 deletions common/chat-parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ bool common_chat_msg_parser::try_parse_reasoning(const std::string & start_think
if (!rest.empty()) {
handle_reasoning(rest, /* closed */ !is_partial());
}
// Allow unclosed thinking tags, for now (https://github.com/ggml-org/llama.cpp/issues/13812, https://github.com/ggml-org/llama.cpp/issues/13877)
// if (!syntax_.thinking_forced_open) {
// throw common_chat_msg_partial_exception(end_think);
// }
return true;
}
}
Expand Down
Loading