Skip to content

llama.cpp with sentencepiece #17529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+702 −64
Open

llama.cpp with sentencepiece #17529

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
afa30d1
teuken tokenizer
net-haus Oct 27, 2025
5fd8e3c
sentencepiece tokenizer for llama.cpp
net-haus Nov 18, 2025
077b059
eos token not added to prompt
net-haus Nov 22, 2025
b73261f
link to sentencepiece with variable
net-haus Nov 25, 2025
a198b51
readme for llama.cpp sentencepiece changed.
net-haus Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
eos token not added to prompt
  • Loading branch information
@net-haus
net-haus committed Nov 22, 2025
commit 077b0593a18cb0a681d4a51925913f6299211253
2 changes: 1 addition & 1 deletion src/llama-vocab-sentencepiece.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "sentencepiece_processor.h"
#include "filesystem.h"
//#include "filesystem.h"
#include "llama-vocab-sentencepiece.h"
#include <string>
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion src/llama-vocab.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,7 +2090,7 @@ void llama_vocab::impl::load(llama_model_loader & ml, const LLM_KV & kv) {
} else if (type == LLAMA_VOCAB_TYPE_SPIE) {
pre_type = LLAMA_VOCAB_PRE_TYPE_DEFAULT;
add_bos = false;
add_eos = true;
add_eos = false;
}
else if (type == LLAMA_VOCAB_TYPE_RWKV) {
pre_type = LLAMA_VOCAB_PRE_TYPE_DEFAULT;
Expand Down
2 changes: 2 additions & 0 deletions tests/test-model-load-cancel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ int main(int argc, char ** argv) {

std::vector<llama_token> tokens = common_tokenize(ctx, str, false, true);

std::vector<llama_token> tokensbos = common_tokenize(ctx, str,true, true);

{
std::vector<llama_chat_message> conversation {
{"user", "Hello, how are you?"},
Expand Down