Fix unreadable user markdown colors and truncate long texts in deletion dialogs #17555
+37
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3e5370 to
cdc3e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
It fixes unreadable colors in user-rendered markdown, where links could appear white on white and table cells could become black on black when hovered. User markdown now uses safe, consistent colors without hover artifacts
It also improves text previews in deletion dialogs by moving getPreviewText into a dedicated utility and ensuring conversation names are properly truncated before being displayed. This prevents overly long titles from breaking dialog layouts
Render user content as Markdown enabled, before :
Render user content as Markdown enabled, after :
Before :
After :